Skip to content

Comments

[fix] 북마크로 방생성 참가자 연결#132

Merged
dltjwls02 merged 1 commit intoON-AIR-mate:mainfrom
dltjwls02:feature/bookmarkCollectionFix1
Aug 19, 2025
Merged

[fix] 북마크로 방생성 참가자 연결#132
dltjwls02 merged 1 commit intoON-AIR-mate:mainfrom
dltjwls02:feature/bookmarkCollectionFix1

Conversation

@dltjwls02
Copy link
Contributor

@dltjwls02 dltjwls02 commented Aug 19, 2025 •
edited by coderabbitai bot
Loading

name: pull_request_template
about: Describe this issue template's purpose here.
title: ''
labels: ''
assignees: ''

🚩 관련 이슈

  • close #[issue_number]

📋 작업 내용

  • 북마크로 방생성 관련 서비스 하단 부에 방 참가자 관련 디비 처리 추가

✨ 주요 변경 사항

✅ 테스트 방법

  • 스웨거 요청 성공 확인 및 디비 확인 완료

💬 기타 사항

Summary by CodeRabbit

  • 신규 기능

    • 북마크에서 방을 생성하면 생성자가 자동으로 호스트로 등록되어, 생성 직후 관리 기능을 바로 사용할 수 있습니다.

  • 버그 수정

    • 북마크 기반 방 생성 후 생성자가 호스트로 표시되지 않거나 권한이 부여되지 않던 문제를 해결했습니다.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 19, 2025 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

  • 북마크로부터 새 방을 생성한 직후, 생성자를 호스트로 등록하는 roomParticipant 레코드를 추가함 (roomId = newRoom.roomId, userId = userId, role = 'host').
  • 이 삽입은 응답을 반환하기 전에 수행됨.
  • 공개/내보낸 시그니처 변경 없음.
  • 반환값(roomId, thumbnail, message)은 기존과 동일함.

Sequence Diagram(s)

sequenceDiagram
  autonumber
  actor User as 사용자
  participant BS as BookmarkService
  participant RR as RoomRepository
  participant RPR as RoomParticipantRepository

  User->>BS: 북마크로 방 생성 요청
  BS->>RR: createRoom(bookmarkId, userId)
  RR-->>BS: newRoom(roomId, thumbnail)
  note over BS: 변경점: 방 생성 직후<br/>참가자(호스트) 등록
  BS->>RPR: insertParticipant(roomId=newRoom.roomId, userId, role='host')
  RPR-->>BS: 삽입 성공
  BS-->>User: { roomId, thumbnail, message }
Loading

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between a9f7388 and cbae805.

📒 Files selected for processing (1)
  • src/services/bookmarkService.ts (1 hunks)
✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@dltjwls02 dltjwls02 merged commit 5930b1f into ON-AIR-mate:main Aug 19, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@dltjwls02